Repository navigation
SQLite, DuckDB, PostgreSQL: Accept ._name after whitespace in a qualified name - #2677
Open
LucaCappelletti94 wants to merge 3 commits into
Open
LucaCappelletti94 wants to merge 3 commits into
LucaCappelletti94 wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
==========================================
+ Coverage 81.31% 81.36% +0.05%
==========================================
Files 42 42
Lines 33977 34040 +63
Branches 33977 34040 +63
==========================================
+ Hits 27628 27697 +69
+ Misses 2785 2783 -2
+ Partials 3564 3560 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
marked this pull request as draft
October 18, 2026 14:12
LucaCappelletti94
force-pushed
the
tokenizer-dot-underscore
branch
from
October 18, 2026 14:13
4052fc2 to
600dc8b
Compare
LucaCappelletti94
marked this pull request as ready for review
October 18, 2026 17:06
LucaCappelletti94
force-pushed
the
tokenizer-dot-underscore
branch
from
October 20, 2026 11:28
32a2953 to
84e9a63
Compare
alamb
approved these changes
Oct 20, 2026
LucaCappelletti94
force-pushed
the
tokenizer-dot-underscore
branch
from
October 21, 2026 07:42
84e9a63 to
29a56d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT t ._a FROM tfailed to tokenize withUnexpected character '_', although SQLite 3.51.1, DuckDB 1.4.4 and PostgreSQL 16 all run it and read it ast._a. The tokenizer treats._as a period only when the previous token is a word, and with whitespace in between the previous token was the whitespace, so it fell through to number parsing.The check now looks at the previous token that is not whitespace. A
._that follows a number, as inSELECT 1 ._a, is still a tokenizer error, andSELECT ._abcwith no qualifier is still rejected by the parser. Tests cover these forms in every dialect where_can start an identifier.